[ Outline ] · Standard · Linear+ Recent Win32UIShell.cpp changes

[Fraggle]

This file's been throwing me since it was altered last week. Couple of problems I think I've found:

1) The calls to SHEmptyRecycleBin are leaving me a bit confused. MSDN claims that the function is valid as far back as Win95 with IE4. However, my version of shellapi.h has it ifdeffed for NTDDI_VERSION >= NTDDI_WIN2K. I'm not sure what MS is playing at here, or if you know something I don't.

2) VC2005 is complaining about line 454

ext.insert( 0, '.' );

saying it can't convert from char to String. The relevant String declarations for insert are

UnicodeString& insert(size_type p0, const AnsiChar *s);

UnicodeString& insert(size_type p0, size_type n, AnsiChar c);

so I guess the choice is

ext.insert( 0, ".");
or
ext.insert( 0, 1, '.'); // at least I think it would be 1

Is the second form quicker as it doesn't need to worry about null-termination?

[Fraggle]

Yeah - using VS2005, and it does throw an error. The temp fix is to set WINVER and _WIN32_WINNT to 0x0500 in FrameworkConfig.h

My SDK version is from VS2008. I haven't tried it yet, but I can't see why it won't fail there either.

I think the first one 'looks' better too. :-) Might as well go with it.